Hi Jeremy, many thanks for your package review. I've been working with the upstream to resolve the key elements. Today upstream have tagged v0.0.2 which I've pushed to mentors.
> 1. I don't like the generic name for /etc/xdg/autostart/autostart . Could that file be named something other than autostart? Notably, files in /etc/ are usually conf files and don't get automatically removed when the package providing them is either removed or stops shipping that filename. I agree here - upstream have fixed this in v0.0.2. For the moment I've overridden in debian/rules to not install the autostart file since we probably will resolve this in budgie-desktop itself. > 2. Could the src/dbus/generated/* files be generated by the Debian build? Maybe those files could be generated by the upstream build system (for everyone) instead of being generated by Taskfile.yml and checked in to git. > If there isn't a new release without those generated files, I suggest adding the files to Files-Excluded: in debian/copyright and excluding them from your orig tarball. That way you make sure that you are building those files from source and you don't have to mention them later in debian/copyright. I raised this upstream and worked with them to resolve. Upstream are now building these dynamically - so this folder has been deleted and I've adjusted d/copyright since this part isn't required. > I don't consider the following issues to be blockers for uploading. 3. Your Vcs links in debian/control don't work. I recommend not mentioning a branch name since the default branch is set correctly already. This is now resolved in the latest mentors upload > 4. The Repository* links in debian/upstream/metadata are pointing to the issues page instead of to the repo. You could maybe add a Bug-Submit line also. Agreed - these have been resolved in the latest mentors upload https://mentors.debian.net/debian/pool/main/b/budgie-desktop-services/budgie-desktop-services_0.0.2-1.dsc > 5. https://moderndesktop.dev/ wasn't loading for me today Upstream has moved to a paid model so this should be ok moving forward. David On Thu, 27 Nov 2025 at 20:12, Jeremy Bícha <[email protected]> wrote: > > 1. I don't like the generic name for /etc/xdg/autostart/autostart . > Could that file be named something other than autostart? Notably, > files in /etc/ are usually conf files and don't get automatically > removed when the package providing them is either removed or stops > shipping that filename. > > 2. Could the src/dbus/generated/* files be generated by the Debian build? > Maybe those files could be generated by the upstream build system (for > everyone) instead of being generated by Taskfile.yml and checked in to > git. > > If there isn't a new release without those generated files, I suggest > adding the files to Files-Excluded: in debian/copyright and excluding > them from your orig tarball. That way you make sure that you are > building those files from source and you don't have to mention them > later in debian/copyright. > > I don't consider the following issues to be blockers for uploading. > 3. Your Vcs links in debian/control don't work. I recommend not > mentioning a branch name since the default branch is set correctly > already. > > 4. The Repository* links in debian/upstream/metadata are pointing to > the issues page instead of to the repo. You could maybe add a > Bug-Submit line also. > > 5. https://moderndesktop.dev/ wasn't loading for me today > > Thank you, > Jeremy Bícha
