Hi, Ian Jackson <[email protected]> (2025-12-28): > Firstly, I should say that I'm sorry to Cyril for this.
Thanks, I know it's not a huge deal, but that's not the first time I go “wait a minute, I didn't do this?!” and I thought I'd ask “officially”… > > I can see why they should be _somehow_ tagged as being his work, > > given that they are representations of uploads he did to the > > archive, but I agree with him that setting both the Author and > > Committer seems to overstep the mark by quite a margin. > > I am inclined to agree, so this was a mistake on my part. I'm raising > the severity of this bug and we will change the way dgit behaves. > > > I'd have thought that setting at least one of those to me would have > > been a more accurate recording of what happened. > > I think the right answer is probably for dgit to set the `committer` > differently. I think we probably ought to retain the `author`. That would look fair to me. > These commits are the results of importing the source package into > git. They represent the various elements of the upload, including the > tarballs and patches. Those are indeed things that the uploading > maintainer produced; they've been transformed from .changes/.dsc to > git. Setting the `author` is a usual way of providing attribution, > even for things that weren't done as git. (For example, I routinely > use `git commit --author` when importing translations supplied as BTS > attachments.) A separate discussion reminded me of Signed-off-by that can be used (as far as I understand/use it) to take responsibility for a given commit. But I'm sure you're well more versed in such topics than I am. > I don't think we want to use the git information belonging to the user > running dgit fetch. It is much better if different users importing > the same .dsc get the same commits. So probably we should use some > fixed standard "dummy" user, with "dgit" in it, for the committer. Thanks for being open to altering the current behavior, I'll happily take whatever adjustments you'll deem appropriate. Cheers, -- Cyril Brulebois ([email protected]) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
