Hi! All seems to be good. I have my last comment before upload it:
- d/copyright: src/gallia/pydantic_argparse/utils/field.py: Seems to be a different copyright holder Please let me know, if you can fix it, or did I misunderstand? Thanks for your work! Quoting Stefan Tatschner (2025-12-30 09:25:55) > Hi Emmanuel, > > Am Montag, dem 29.12.2025 um 23:09 -0300 schrieb Emmanuel Arias: > > Hi Stefan, > > > > I took gallia to review. Thanks for the work. I leave you some > > comments for now: > > thank you very much for your time reviewing my package! I have pushed a > new version of the package here [1,3] where your remarks have been > addressed accordingly. I also will upload a new version to mentors, > once the rate-limit lets me in again [2]. Might be in a few hours. > > > - d/upstream/metadata: Changelog get 404 > > - d/upstream/metadata: Documentation get 404 > > - d/control: Homepage seems to be incorrect. > > - d/copyright: Please use Expat instead of MIT. > > - d/control: You can set all B-depends used *only* in tests with > <!nocheck>. > > We had some upstream changes here that were not yet addressed by the > proposed package. This is now fixed in the new package version. > Further, gallia 2.0 is now released, so there is no beta tag in the > version any more. > > > - tests/bats/testfiles/log-01.json.zst: This file is necessary to > > work? or it's just used in test? The test is important? > > This is a testfile for our logfile parser which is tested in the bats > e2e tests. I enabled those tests to be executed by autopkgtest. log- > 01.json.zst is required by those tests. > > As far as I understand the packaging process, the file needs to be > present in the source package in order to perform those tests in the > debian CI. > > > - Please review d/copyright file, for instance file > > src/gallia/pydantic_argparse/utils/field.py is Apache-2.0, but in > > d/copyright says MIT. > > Good catch, that's a tricky special case. That's the only file of that > special case. Fixed. > > > I stop review it here. Please let me know when you have a new version > > to review. > > > > Thanks! > > Thanks! > Stefan > > [1]: > https://salsa.debian.org/python-team/packages/gallia/-/tree/debian/latest > [2]: https://mentors.debian.net/package/gallia/ > [3]: > https://salsa.debian.org/python-team/packages/gallia/-/commit/da48025535db51bd9ec0d420b3e86b36e5c8d74d > cheers, Emmanuel Arias ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ [email protected] ⢿⡄⠘⠷⠚⠋⠀ OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1 ⠈⠳⣄
