tags 919926 patch
thanks

Hello Geert.

The reason this package disables the tests is that they do not work.
More specifically, "make check" tries to build some programs and the
compilation fails with this linking error:

./test/util.c:264:(.text+0x51): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function `iface_setup':
./test/util.c:179:(.text+0xde): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function 
`test_safe_buffer_list_fn':
./test/util.c:83:(.text+0x5ec): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function 
`test_check_dnssl_presence_fn':
./test/util.c:198:(.text+0x76f): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function 
`test_safe_buffer_fn':
./test/util.c:23:(.text+0x990): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o:./test/util.c:223: more 
undefined references to `_mark_point' follow
collect2: error: ld returned 1 exit status


So disabling the tests is currently necessary and justified.

However, there is a problem in the way the tests are skipped.
The package uses DEB_BUILD_OPTIONS in debian/rules, which triggers
a lintian warning. I agree with lintian here. The DEB_BUILD_OPTIONS
variable is reserved to be used by whoever is building the package,
not by debian/rules.

In this particular case, we want the tests not to run during build,
because they do not work, and we already have a good way to do that,
which is to have a rule called override_dh_auto_test which does
nothing.

Please consider the attached patch, which also removes the
lintian override, as it becomes no longer necessary.

[ Note: Not sure if this bug was about tracking how to re-enable the tests,
  or about why the tests are disabled in the specific way they are
  currently disabled, causing a lintian warning etc.

  So, feel free to drop the Closes statement in the attached patch if
  you still want to keep this bug open with the meaning "I would like
  to run the tests" ].

Thanks.
commit 84905382066785a6b1be6ced32f8001f7169d1e6
Author: Santiago Vila <[email protected]>
Date:   Mon Feb 2 16:45:00 2026 +0100

    Use override_dh_auto_test to skip tests. Closes: #919926.

diff --git a/debian/rules b/debian/rules
index 3dc5495..635321e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,7 +2,6 @@
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 export DEB_LDFLAGS_MAINT_APPEND = -lcheck_pic
-export DEB_BUILD_OPTIONS=nocheck
 
 %:
        dh $@ --with autoreconf
@@ -18,3 +17,5 @@ override_dh_auto_clean:
 
 override_dh_installinit:
        dh_installinit --error-handler=true
+
+override_dh_auto_test:
diff --git a/debian/source/lintian-overrides b/debian/source/lintian-overrides
deleted file mode 100644
index 9451461..0000000
--- a/debian/source/lintian-overrides
+++ /dev/null
@@ -1,7 +0,0 @@
-#
-# build tests are disabled
-debian-rules-sets-DEB_BUILD_OPTIONS
-# why is tracked in #919926
-# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919926
-
-# l l

Reply via email to