Hi Santiago, > Trying to build source after a binary build results in this error: > > dpkg-source: info: local changes detected, the modified files are: > raster3d-3.0-8/Makefile.incl > dpkg-source: error: aborting due to unexpected upstream changes, see > /tmp/raster3d_3.0-8-2.diff.SBkmKl
Good catch, that's on me forgetting to check that build pattern, thanks! > I'm attaching a patch which works for me, the patch "prevent_etc" does not > seem necessary, > and everything seems to work ok if we remove Makefile.incl in the clean target > (or debian/clean) and create it as an empty file as the very first to do when > building the package. > > This is probably the spirit of the upstream code, except that they decided to > ship > a non-empty Makefile.incl in the upstream tarball, which seems a little bit > inconsistent to me... > > I would normally apply the patch and make a team upload, but you clearly spent > some time thinking about this, so I wanted to ask first: Do you see any > other way (maybe better) to fix the ftbfs-source-after-build issue? I looked up your proposal and I like it: your work fixes the issue, including in the double build case, and it is less intrusive than having the quilt patch. Please fell free to go ahead an upload your change. Have a nice day, :) -- .''`. Étienne Mollier <[email protected]> : :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/pts/1, please excuse my verbosity `- on air: Reinecke - Trio avec piano n°1
signature.asc
Description: PGP signature
