On 12/02/2026 20:34, Adrian Bunk wrote:
On Thu, Feb 12, 2026 at 08:01:55PM +0100, Lee Garrett wrote:
Hi Adrian,
On 12/02/2026 16:06, Adrian Bunk wrote:
Source: borgbackup
Version: 1.4.3-2
Severity: important
borgbackup (1.4.3-2) unstable; urgency=medium
...
* Skip build tests when running with DEB_BUILD_OPTIONS=nocheck.
...
-- Lee Garrett <[email protected]> Sun, 21 Dec 2025 22:35:39 +0100
This change was obviously never tested, because otherwise it would
have been noticed before uploading that the condition is inverted
and tests are now skipped when nocheck is *dis*abled.
Testing the change would have also revealed that no change was
necessary at all, as documented dh_auto_test is automatically
skipped with nocheck.
Please revert this bogus change.
Thanks for pointing out the bug. Indeed, you are correct that the test logic
is inverted.
I did actually test this, and retested it right now, and just deleted the
first draft of this mail after finding the actual issue in my setup.
Turns out that I set DEB_BUILD_OPTIONS in my ~/.sbuildrc, and that takes
higher precedence than what is set on the CLI. Which is also the reason I
added the conditional in the first place; dh_auto_test didn't seem to behave
as documented.
Your change did not disable running the tests with nocheck.
I'm agreeing with you.
If dh_auto_test didn't seem to behave as documented as you claim,
and you did test your change as you claim, then you would have
seen that tests are still running with nocheck set.
I'm going to read good intentions here and assume you didn't understand what I
said. This might clarify how the bug came into effect:
# set many aeons ago
$ grep DEB_BUILD ~/.sbuildrc
$ENV{'DEB_BUILD_OPTIONS'} = 'parallel=8';
# pre-change source tree
$ DEB_BUILD_OPTIONS=nocheck sbuild
<tests run>
## add conditional
$ DEB_BUILD_OPTIONS=nocheck sbuild
<tests don't run>
Due to the option in .sbuildrc DEB_BUILD_OPTIONS=nocheck was overwritten to
DEB_BUILD_OPTIONS='parallel=8'. I could have of course noticed by running
`sbuild` without env var on the CLI, and noticed that the tests aren't run
either. But since I ran the autopkgtests before uploading I didn't think that
was needed.
After finding out that .sbuildrc overrode the env var set on the CLI I
understand that the logic was inverted, and not needed in the first place. I'm
just pointing out that I didn't upload changes without ever testing it, I just
tested the wrong things.
The only effect of your change was disabling the tests when nocheck
was NOT set.
Actually, they never run; if it's unset, my buggy check skips them. If it's set,
dh_auto_test gets skipped altogether:
dh: command-omitted: The call to "debian/rules override_dh_auto_test" was
omitted due to "DEB_BUILD_OPTIONS=nocheck"
Greets,
Lee
cu
Adrian
Greets,
Lee
