On Sat, 2026-02-21 at 13:04 +0100, Tobias Frost wrote:
> - d/README.upstream
> 
> This file doesn't really have relevant information for Debian users
> installing the binary package; if, then the extra information about
> the
> package should be part of the long description. 
> The installation section is mood for binary packages.
> 
> The usage part should be part of the manpage.
> 
> I'd drop that file.
> 
> (Dropping d/README and d/README.source was the right thing)
> 
> - d/changelog.upstream
> 
> This seems to be a relict from the previous packages - drop it.
> 
I dropped d/README.upstream and d/changelog.upstream.
> - d/control
> 
> The long description needs updating, see Debian Policy §3.4
> - License information go to d/copyright, not to the long description.
> - "It is not copyrighted." - can you expand what you mean?
>   (In many countries something cannot not be legally "not
> copyrighted",
>   as e.g in Germany a author cannot legally not havin copyright.)
>   It seems to be contradicting information in d/copyright.
>   Please clarify & and fix.
> 
Now long description of fortunes-dhammapada only contains editions'
translators and languages. I also checked and fixed names in
d/copyright and d/control.
> lintian:
> I: fortunes-dhammapada: spare-manual-page
> [usr/share/man/man1/fortunes-dhammapada.1.gz]
> 
> (maybe the manpage is in the wrong section - section 1 is for
> executables / programs.)
I applied a patch to fix man pages and updated d/rules to rename them.
Now they are in section 6, so there will be no such lintian warning.

Additionally, I added a new dependence "gawk"for display-dhammapada,
for the upstream code depends on it to work properly.

The updated code is available on
https://salsa.debian.org/tzbkk/display-dhammapada

Thanks for your review!

Regards,
Haolin Xue

Reply via email to