Package: devscripts
Version: 2.26.5
Severity: important

In attempting to get rcs-blame to build on salsa, I found that uscan's
behavior for versionmangle is broken (I'm unable to work around this in
any other way than this bug report).  The reason for this is an incorrect
parameter passed to the "grep" command in 

        /usr/share/perl5/Devscripts/Uscan/Modes/_xtp.pm

This is an untyped reference, which used to be a hash, but became an array
in the upgrade.  But that doesn't work with the grep command, and since the
failure is silent, unnoticed.

Rather than use the untyped reference, the script already has a validated
variable with the proper contents.  With this change, the script works with
both version 4 and version 5 watch files:

--- /usr/share/perl5/Devscripts/Uscan/Modes/_xtp.pm.orig        2025-10-24 
03:20:45.000000000 -0400
+++ /usr/share/perl5/Devscripts/Uscan/Modes/_xtp.pm     2026-03-11 
20:41:14.360654826 -0400
@@ -103,7 +103,7 @@
         and not $watchSource->versionmode eq 'ignore') {
 
         # extract ones which has $match in the above loop defined
-        my @vfiles = grep { $$_[3] } @files;
+        my @vfiles = grep { $watchSource->shared->{download_version} } @files;
         if (@vfiles) {
             (undef, $mangled_newversion, $newfile, undef, $newversion)
               = @{ $vfiles[0] };

This isn't the same issue as reported in #1122181.

-- Package-specific info:

--- /etc/devscripts.conf ---
Empty.

--- ~/.devscripts ---
Not present

-- System Information:
Debian Release: forky/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.18.15+deb14-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages devscripts depends on:
ii  dpkg-dev                 1.23.7
ii  file                     1:5.46-5+b1
ii  gpg                      2.4.9-4
ii  gpg-agent                2.4.9-4
ii  gpgv                     2.4.9-4
ii  libconfig-inifiles-perl  3.000003-4
ii  libdpkg-perl             1.23.7
ii  libfile-dirlist-perl     0.05-3
ii  libfile-homedir-perl     1.006-2
ii  libfile-touch-perl       0.12-2
ii  libio-string-perl        1.08-4
ii  libmoo-perl              2.005005-1
ii  libwww-perl              6.81-1
ii  patchutils               0.4.3-1
ii  perl                     5.40.1-7
ii  python3                  3.13.9-3
ii  sensible-utils           0.0.26
ii  wdiff                    1.2.2-9

Versions of packages devscripts recommends:
ii  apt                         3.1.16
ii  curl                        8.18.0-2
ii  dctrl-tools                 2.24-3+b1
ii  debian-keyring              2025.09.18
ii  debian-tag2upload-keyring   1.2
ii  dput                        1.2.4
ii  equivs                      2.3.2
ii  git-debpush                 14.10
ii  libdistro-info-perl         1.15
ii  libencode-locale-perl       1.05-3
ii  libgitlab-api-v4-perl       0.27-1
ii  libjson-perl                4.10000-1
ii  liblwp-protocol-https-perl  6.15-1
ii  libmetacpan-client-perl     2.038000-1
ii  libsoap-lite-perl           1.27-3
ii  libstring-shellquote-perl   1.04-3
ii  liburi-perl                 5.34-2
ii  licensecheck                3.3.9-1
ii  lintian                     2.130.1
ii  lzip                        1.26~rc1-2
ii  man-db                      2.13.1-1
ii  patch                       2.8-2
ii  pristine-tar                1.50+nmu2
ii  python3-apt                 3.1.0
ii  python3-debian              1.1.0
ii  python3-magic               2:0.4.27-3
ii  python3-requests            2.32.5+dfsg-1
ii  python3-unidiff             0.7.5-2
ii  python3-xdg                 0.28-3
ii  strace                      6.18+ds-2
ii  unzip                       6.0-29
ii  wget                        1.25.0-2
ii  xz-utils                    5.8.2-2

Versions of packages devscripts suggests:
pn  adequate                                   <none>
pn  at                                         <none>
pn  autopkgtest                                <none>
pn  bls-standalone                             <none>
ii  bsd-mailx [mailx]                          8.1.2-0.20220412cvs-1.1
ii  build-essential                            12.12
pn  check-all-the-things                       <none>
ii  debhelper                                  13.31
pn  diffoscope                                 <none>
pn  disorderfs                                 <none>
pn  docker.io                                  <none>
pn  dose-extra                                 <none>
pn  duck                                       <none>
pn  elpa-devscripts                            <none>
ii  exim4-daemon-light [mail-transport-agent]  4.99.1-1
pn  faketime                                   <none>
pn  gnuplot                                    <none>
pn  how-can-i-help                             <none>
ii  libauthen-sasl-perl                        2.2000-1
pn  libdbd-pg-perl                             <none>
pn  libterm-size-perl                          <none>
ii  libtimedate-perl                           2.3400-1
ii  libyaml-libyaml-perl                       0.904.0+ds-1
pn  mmdebstrap                                 <none>
ii  mutt                                       2.2.13-1+b1
ii  openssh-client [ssh-client]                1:10.2p1-5
pn  piuparts                                   <none>
pn  postgresql-client                          <none>
pn  pristine-lfs                               <none>
ii  python3-debianbts                          4.1.1
ii  python3-pycurl                             7.45.7-3+b1
ii  quilt                                      0.69-0.1
pn  ratt                                       <none>
pn  reprotest                                  <none>
pn  svn-buildpackage                           <none>
ii  w3m                                        0.5.3+git20230121-2.3

-- no debconf information

-- 
Thomas E. Dickey <[email protected]>
https://invisible-island.net

Attachment: signature.asc
Description: PGP signature

Reply via email to