Xiyue Deng <[email protected]> writes:
> Łukasz Stelmach <[email protected]> writes:
>
>>  
>> I was trying to report a bug in the inkscape package via emacs' debian-bug
>> command. But the report wasn't properly prefilled as it used to be.
>>  
>> I debugged debian-bug.el and found out that reportbug called on line
>> 766[1] returns "1" and fails to return any output. I called the very
>> same command from a shell and it succeded (there was some reasonable
>> output). However when I set the HOME environment variable to an empty
>> string "", reportbug printed the following error message:
>>  
>>     Unable to identify a valid from address, please run 'reportbug 
>> --configure'
>>  
>> The lisp code didn't handle this situation properly and didn't show any
>> error message.
>>  
>> To work around this problem, I set EMAIL environment to my e-mail addres
>>  
>>     (setenv "EMAIL" "[email protected]")
>>  
>> before running debian-bug.
>>
>> [1] 
>> https://salsa.debian.org/emacsen-team/debian-el/-/blob/master/debian-bug.el?ref_type=heads#L766
>>
>
> Thanks for your report! As you have identified, the actual cause is that
> without a valid email address in environmental variable DEBEMAIL,
> REPORTBUGEMAIL, or EMAIL, reportbug will fail to run. So HOME is not the
> real cause here. I have adjusted the bug title accordingly.

>From my perspective as a user this is the root cause, because I've got
my email address configured in ~/.reportbugrc since very long time ago
and up until triexie there were no problems, because reportbug was able
to find the configuration and read the address. And the HOME patch
appear to be merged between releasing bookworm and triexie. Hence, I
believe this can be called a regression and the best fix (albeit
cumbersome, I admit) would be to read the email form ~/.reportbugrc
file.

That is not to say your fix isn't right, but I prefere not having the
EMAIL (which may be used by other programs) variable set because in
general my e-email setup is flaky and I prefere seeing software fail
rather than sending and e-mail from a wrong address.

> I prepared a fix to check for a valid email in those envvars and fail
> early if cannot find one. It should appear in experimental soon. Please
> help test.

I will.
-- 
Miłego dnia,
Łukasz Stelmach

Reply via email to