Hi,

For instance for radicale, see https://bugs.debian.org/1130672 .

> > Is /usr/share/doc/uwsgi-core/README.Debian not enough?
>
> No, it is not enough, a multiple things are missing.

Then please suggest some proper writing!

> First, the section "Initscript for running uWSGI daemon" has to be
> dropped as it is misleading, especially when old init script doesn't
> work:

Again, not sure the sysv init conf and doc should be dropped, maybe
moved to some legacy ยง. These might be used in Debian derivatives.

> Second, socket's path was changed, thus enabling .socket unit is not
> enough, as one need to change nginx's (in my case) config. The old
> System-V init script for apps-enabled/cgi.ini sets:
>
>     /run/uwsgi/app/cgi/socket
>
> Now it is created by .socket unit (and from apps-available) as:
>
>     /run/uwsgi/cgi.socket

Good catch, simple fix.

> Third, the old init script starts the app with default.ini, now it is
> not included, thus some options can be missing now and it needs
> inspection. It is not mentioned too.

This is difficult to fix as I do not know how this might be used
by users.

> Fourth, not as important, but why both units are enabled? Enabling
> .socket unit must be enough, worst enabling .service unit can be
> misleading, as stopping it will not be enough, as .socket unit will
> start it again on socket access. Remove enabling .service from README.
> And simplify that enable & start by "enable --now"

Good catch, this line is in fact useless.

> Last and IMO most important, the NEWS is missing, after upgrade all
> previously configured uwsgi apps just do not start (uwsgi.service unit
> is missing as you can see in first snippet). It was enabled by some
> systemd's magic, and thus after upgrade (and restart) one can notice
> this too late. That is not expected...

I see your point but this is caused by the systemd upgrade, not any change
in uwsgi, so I would not know which version of uwsgi to attach that NEWS to...

> BTW, consider remove the /etc/uwsgi/apps-enabled directory from package
> at all, it is not needed anymore...

Again, not sure about removing sysv init conf.

Thanks!

Alex

Reply via email to