The Debian NEW review of mstpd 0.2.0-1 has been completed. Decision: REJECTED Reviewer: Reinhard Tartler
Review comment: Thanks for your diligence while working on this package. I've had a look through the source, and while it's mostly there, I have to reject it for now because there are several discrepancies between the file headers and the claims in debian/copyright. Specifically, several files are licensed under the GPL-2 only, but are currently documented as GPL-2+ (version 2 or later). For example: - broadcom_xstrata/bcmexp.c: L7 says "Released under GPLv2" - broadcom_xstrata/stp.soc: L2 says "Released under GPLv2" - broadcom_xstrata/knet.soc: L2 says "Released under GPLv2" This also applies to broadcom_xstrata/etc-init.d-stp.sh, which lacks an explicit license grant but is presumably intended to be GPL-2 like its neighbors. You'll need to ensure Phybridge Inc is correctly credited for this file under the appropriate GPL-2 stanza. Additionally, list.h contains a note stating it was "grubbed from linux kernel source code". Since the Linux kernel is licensed under GPL-2 only, this header should also be treated as GPL-2 only rather than the GPL-2+ listed in debian/copyright. The broadcom_xstrata/* stanza in debian/copyright is also a bit too broad, as it includes broadcom_xstrata/driver_deps.c, which actually is licensed as GPL-2+ (L7: "version 2 of the License, or (at your option) any later version"). You'll need to split these out into separate stanzas to accurately reflect the "or later" status of each file. Please update debian/copyright to match these findings and re-upload. -rt Full review details: https://dfsg-new-queue.debian.org/reviews/mstpd
