The Debian NEW review of yq-go 4.53.2-2 has been completed.

Decision: REJECTED
Reviewer: Reinhard Tartler

Review comment:

Thanks for your diligence in bringing yq-go to the archive. I've


had another look through the source, and while it's mostly there,


I have to reject it for now because of a few minor metadata and


policy issues.





I noticed a slight slip in the way copyright statements are handled


in debian/copyright. The statements need to be reproduced


verbatim from the source headers to accurately reflect the upstream


notices. For instance, the notice for scripts/shunit2 should


include the "All Rights Reserved" portion, and the entry for


scripts/release-deb.sh should match the exact format of the


header, including the (C) symbol and email address.





This is also a bit of a DFSG problem regarding the embedded copy of


the shunit2 framework in scripts/shunit2. While it is correctly


licensed, Debian Policy §4.13 generally prefers using the packaged


version from the archive. If you find it necessary to bundle it,


please include a debian/README.source file that documents this


embedded copy and explains why the system-wide package isn't being


used instead.





Lastly, there are some formatting bits in the copyright file to


clean up. The Apache-2.0 license should have its own standalone


stanza at the bottom of the file that points to the common


licenses directory, rather than having the reference nested inside


the file stanza. I also noticed that the License: Expat string is


repeated as the first line of the license text block in the main


stanza, which should be removed.





Once these bits are polished, it should be ready for another look.





-rt

Full review details: https://dfsg-new-queue.debian.org/reviews/yq-go

Reply via email to