Source: codelite
Version: 17.0.0+dfsg-6
Usertags: pidof-without-procps

Dear maintainer(s) of codelite,

it appears that codelite uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of codelite
  that use `pidof` at runtime;
* via the `Build-Depends:` field of codelite, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of codelite, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that codelite uses `pidof` due to the following
code snippets:

```
path: codelite_17.0.0+dfsg-6/ctags/Tmain/unreadable-input.d/run.sh
fi
if ! pidof auditd > /dev/null 2>&1; then
        # sudo expects auditd is running.
        skip "auditd is not running"


path: codelite_17.0.0+dfsg-6/ctags/Tmain/unreadable-input.d/run.sh
. ../utils.sh
if ! type pidof > /dev/null 2>&1; then
        # pidof is needed to find auditd.
        skip "pidof command is not available"


path: codelite_17.0.0+dfsg-6/codelite_open_helper.py
pidof_subprocess = subprocess.Popen('pidof codelite', stdout=subprocess.PIPE, 
shell=True)
found_codelite = False
with pidof_subprocess.stdout as txt:
    for line in txt:
        line = line.strip()
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to