Source: conky
Version: 1.22.3-1
Usertags: pidof-without-procps
Dear maintainer(s) of conky,
it appears that conky uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of conky
that use `pidof` at runtime;
* via the `Build-Depends:` field of conky, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of conky, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that conky uses `pidof` due to the following
code snippets:
```
path: conky_1.22.3-1/src/core.cc
char buf[DEFAULT_TEXT_BUFFER_SIZE];
snprintf(buf, DEFAULT_TEXT_BUFFER_SIZE, "pidof %s >/dev/null", arg);
obj->data.s = STRNDUP_ARG;
/* XXX: maybe use a different callback here */
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
