Source: copyq
Version: 13.0.0-1.1
Usertags: pidof-without-procps
Dear maintainer(s) of copyq,
it appears that copyq uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of copyq
that use `pidof` at runtime;
* via the `Build-Depends:` field of copyq, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of copyq, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that copyq uses `pidof` due to the following
code snippets:
```
path: copyq_13.0.0-1/shared/copyq-completion
;;
read)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq read -- ?)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
selection)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq selection -- ?)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
write)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq clipboardFormatsToSave)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
config)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq config | grep '^[^ ]')"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
renametab)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq tab)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
tab)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq tab)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
case "${COMP_WORDS[$COMP_CWORD-1]}" in
show)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq tab)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
copy)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq clipboardFormatsToSave)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
clipboard)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq clipboard -- ?)"
;;
path: copyq_13.0.0-1/shared/copyq-completion
;;
removetab)
pidof copyq &>/dev/null || return
_copyq_complete_lines "$(copyq tab)"
;;
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
