Source: damo
Version: 3.2.3-1
Usertags: pidof-without-procps
Dear maintainer(s) of damo,
it appears that damo uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of damo
that use `pidof` at runtime;
* via the `Build-Depends:` field of damo, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of damo, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that damo uses `pidof` due to the following
code snippets:
```
path: damo_3.1.8-1/src/_damon_modules.py
['pidof', 'kdamond.0']).decode().strip()
except Exception as e:
return None, 'pidof kdamond.0 fail (%s)' % e
intervals = _damon.DamonIntervals()
intervals.intervals_goal = _damon.DamonIntervalsGoal(
path: damo_3.1.8-1/src/_damon_modules.py
try:
kdamond_pid = subprocess.check_output(
['pidof', 'kdamond.0']).decode().strip()
except Exception as e:
return None, 'pidof kdamond.0 fail (%s)' % e
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
