Source: dnssec-trigger
Version: 0.17+repack-5.3
Usertags: pidof-without-procps
Dear maintainer(s) of dnssec-trigger,
it appears that dnssec-trigger uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of dnssec-trigger
that use `pidof` at runtime;
* via the `Build-Depends:` field of dnssec-trigger, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of dnssec-trigger, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that dnssec-trigger uses `pidof` due to the following
code snippets:
```
path: dnssec-trigger_0.17+repack-5.3/01-dnssec-trigger.in
######################################################
# add forward zones into unbound using unbound-control
if [ -n "`pidof unbound`" ]; then
if [ -r "$conn_zones_file" ]; then
for domain in `cat $conn_zones_file`; do
path: dnssec-trigger_0.17+repack-5.3/01-dnssec-trigger.in
############################################################
# configure global nameservers using dnssec-trigger-control
if [ -n "`pidof dnssec-triggerd`" ] ; then
dnssec-trigger-control submit "$global_nameservers" > /dev/null 2>&1
logger "dnssec-trigger-hook(networkmanager) $ifname $action added global
DNS $global_nameservers"
path: dnssec-trigger_0.17+repack-5.3/dnssec-trigger-script.in
pids = list()
try:
output = subprocess.check_output(['pidof', process_name])
p = [int(pid) for pid in output.decode().strip().split()]
pids.extend(p)
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
