Source: dlt-daemon
Version: 3.0.0-8
Usertags: pidof-without-procps
Dear maintainer(s) of dlt-daemon,
it appears that dlt-daemon uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of dlt-daemon
that use `pidof` at runtime;
* via the `Build-Depends:` field of dlt-daemon, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of dlt-daemon, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that dlt-daemon uses `pidof` due to the following
code snippets:
```
path: dlt-daemon_3.0.0-4/tests/start_logstorage_test.sh
rm -rf $pathTmp/$folderName
fi
pidof dlt-daemon > /dev/null
if [ $? -eq '0' ]
then
path: dlt-daemon_3.0.0-4/testscripts/Ubuntu/dlt-daemon.cmake
fi
pidofdlt=`pidof $DESC`
if [ $pidofdlt ]
then
path: dlt-daemon_3.0.0-4/testscripts/Ubuntu/dlt-daemon.cmake
pidofdlt=`pidof $DESC`
if [ $pidofdlt ]
then
log_daemon_msg "$NAME has the PID:$pidofdlt"
path: dlt-daemon_3.0.0-4/tests/start_multinode_test.sh
PIDOF()
{
pidof $1 > /dev/null
return $?
}
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
