Source: gnocchi
Version: 4.7.0-4
Usertags: pidof-without-procps
Dear maintainer(s) of gnocchi,
it appears that gnocchi uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of gnocchi
that use `pidof` at runtime;
* via the `Build-Depends:` field of gnocchi, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of gnocchi, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that gnocchi uses `pidof` due to the following
code snippets:
```
path: gnocchi_4.7.0-3/run-upgrade-tests.sh
done
for PID in $(pidof gnocchi-metricd); do
echo "Configuring dump of MetricD process [PID=${PID}] outputs to avoid
freeze while processing because the logs are not read from buffer"
cat /proc/${PID}/fd/1 >> ${METRICD_LOG_FILE} &
path: gnocchi_4.7.0-3/run-upgrade-tests.sh
UWSGI_LOG_FILE=/tmp/uwsgi-new-version.log
METRICD_LOG_FILE=/tmp/gnocchi-metricd-new-version.log
for PID in $(pidof uwsgi); do
echo "Configuring dump of uWSGI process [PID=${PID}] outputs to avoid freeze
while processing because the logs are not read from buffer"
cat /proc/${PID}/fd/1 >> ${UWSGI_LOG_FILE} &
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
