Source: gdnsd
Version: 3.8.3-2.1+b1
Usertags: pidof-without-procps
Dear maintainer(s) of gdnsd,
it appears that gdnsd uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of gdnsd
that use `pidof` at runtime;
* via the `Build-Depends:` field of gdnsd, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of gdnsd, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that gdnsd uses `pidof` due to the following
code snippets:
```
path: gdnsd_3.8.3-2.1/debian/tests/daemon
set -e
if pidof -x gdnsd > /dev/null; then
echo "OK: gdnsd process running"
# the following exits non-zero if the daemon can't be reached
path: gdnsd_3.8.3-2.1/debian/tests/common-operations
set -e
if ! pidof -x gdnsd > /dev/null; then
echo "Test skipped, gdnsd is not running"
exit 77
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
