Source: incus
Version: 7.0.0-1
Usertags: pidof-without-procps
Dear maintainer(s) of incus,
it appears that incus uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of incus
that use `pidof` at runtime;
* via the `Build-Depends:` field of incus, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of incus, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that incus uses `pidof` due to the following
code snippets:
```
path: incus_6.0.5-8/test/extras/stresstest.sh
# kill the daemons which share our pgrp as parent
mygrp="$(awk '{ print $5 }' /proc/self/stat)"
for p in $(pidof incus); do
pgrp="$(awk '{ print $5 }' "/proc/$p/stat")"
if [ "$pgrp" = "$mygrp" ]; then
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
