Source: knot
Version: 3.5.4-2
Usertags: pidof-without-procps
Dear maintainer(s) of knot,
it appears that knot uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of knot
that use `pidof` at runtime;
* via the `Build-Depends:` field of knot, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of knot, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that knot uses `pidof` due to the following
code snippets:
```
path: knot_3.5.3-2/python/knot_exporter/knot_exporter/knot_exporter.py
out = dict()
try:
pids = subprocess.check_output(['pidof', 'knotd']).decode().split()
for pid in pids:
out[pid] = psutil.Process(int(pid)).memory_info()._asdict()['rss']
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
