Source: lomiri
Version: 0.5.0-10
Usertags: pidof-without-procps

Dear maintainer(s) of lomiri,

it appears that lomiri uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of lomiri
  that use `pidof` at runtime;
* via the `Build-Depends:` field of lomiri, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of lomiri, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that lomiri uses `pidof` due to the following
code snippets:

```
path: 
lomiri_0.5.0-8/tests/autopilot/lomiri/shell/tests/test_system_integration.py
        # invoke policykit to check permissions
        pid = subprocess.check_output(
            ["pidof", "-s", "lomiri"], universal_newlines=True)
        subprocess.check_call(
            "pkcheck --action-id "
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to