Source: mate-session-manager
Version: 1.26.1-3
Usertags: pidof-without-procps

Dear maintainer(s) of mate-session-manager,

it appears that mate-session-manager uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of mate-session-manager
  that use `pidof` at runtime;
* via the `Build-Depends:` field of mate-session-manager, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of mate-session-manager, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that mate-session-manager uses `pidof` due to the following
code snippets:

```
path: mate-session-manager_1.26.1-3/mate-session/gsm-manager.c
{
       int num_processes;
       char * command = g_strdup_printf ("pidof %s | wc -l", name);
       FILE *fp = popen(command, "r");
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to