Source: multipath-tools
Version: 0.14.3-3
Usertags: pidof-without-procps
Dear maintainer(s) of multipath-tools,
it appears that multipath-tools uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of multipath-tools
that use `pidof` at runtime;
* via the `Build-Depends:` field of multipath-tools, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of multipath-tools, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that multipath-tools uses `pidof` due to the following
code snippets:
```
path: multipath-tools_0.14.3-2/debian/initramfs/hooks/multipath
# used by our scripts
copy_exec /usr/bin/grep
copy_exec /usr/bin/pidof
copy_exec /usr/sbin/dmsetup
path: multipath-tools_0.14.3-2/debian/initramfs/scripts/init-bottom/multipath
pid_file="$(cat /run/multipathd.pid)"
if [ "${pid_pidof}" = "${pid_file}" ]; then
kill ${pid_pidof}
verbose && log_end_msg
path: multipath-tools_0.14.3-2/debian/initramfs/scripts/init-bottom/multipath
verbose && log_begin_msg "Stopping multipathd"
pid_pidof="$(pidof multipathd)"
pid_file="$(cat /run/multipathd.pid)"
path: multipath-tools_0.14.3-2/debian/initramfs/scripts/init-bottom/multipath
verbose && log_end_msg
else
verbose && log_failure_msg "inconsistent PIDs (pidof: '${pid_pidof}',
multipathd.pid: '${pid_file}')"
fi
path: multipath-tools_0.14.3-2/debian/tests/initramfs
echo "check helper programs are installed in initramfs"
find_file 'grep'
find_file 'pidof'
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
