Source: nftlb
Version: 1.0.7-1+b2
Usertags: pidof-without-procps
Dear maintainer(s) of nftlb,
it appears that nftlb uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of nftlb
that use `pidof` at runtime;
* via the `Build-Depends:` field of nftlb, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of nftlb, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that nftlb uses `pidof` due to the following
code snippets:
```
path: nftlb_1.0.7-1/tests/api/api_tests.sh
echo "" > /var/log/syslog
kill -9 `pidof nftlb` 2> /dev/null
$NFTBIN flush ruleset
$NFTLBIN $NFTLB_ARGS -d -k "$APISRV_KEY" -H $APISRV_ADDR -P $APISRV_PORT -l
$DEBUG > /dev/null
path: nftlb_1.0.7-1/tests/api/api_tests.sh
if [ $STOPPED -eq 0 ]; then
$NFTBIN flush ruleset
kill `pidof nftlb`
fi
path: nftlb_1.0.7-1/tests/exec_tests.sh
if [ $APISERVER -eq 1 ]; then
kill `pidof nftlb`
fi
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
