Source: nsntrace
Version: 4.5.g4d02e74-1+b1
Usertags: pidof-without-procps
Dear maintainer(s) of nsntrace,
it appears that nsntrace uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of nsntrace
that use `pidof` at runtime;
* via the `Build-Depends:` field of nsntrace, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of nsntrace, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that nsntrace uses `pidof` due to the following
code snippets:
```
path: nsntrace_4.5.g4d02e74-1/tests/check_namespaced.sh
# stop the non-namespaced udp_send on exit
pidof_udp_send=$(pidof udp_send)
trap 'kill "$pidof_udp_send"' EXIT
# make sure we only capture the packets from the namespaced version
path: nsntrace_4.5.g4d02e74-1/tests/check_cleanup.sh
sudo ../src/nsntrace ./test_program_dummy.sh &
sleep "$timeout"
pid=$(pidof nsntrace)
sudo kill "-$sig" "$pid"
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
