Source: openscap
Version: 1.4.4+dfsg-1
Usertags: pidof-without-procps
Dear maintainer(s) of openscap,
it appears that openscap uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of openscap
that use `pidof` at runtime;
* via the `Build-Depends:` field of openscap, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of openscap, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that openscap uses `pidof` due to the following
code snippets:
```
path:
openscap_1.4.3+dfsg-1/tests/probes/systemdunitdependency/test_probes_systemdunitdependency.sh
function test_probes_systemdunitdependency {
probecheck "systemdunitdependency" || return 255
pidof systemd > /dev/null || return 255
systemctl > /dev/null 2>&1 || return 255
path: openscap_1.4.3+dfsg-1/tests/oval_details/test_oval_details.sh
test_run "test_oval_details_rpminfo_object_implicit" test_oval_details_implicit
rpminfo "name.*release.*version" "rpm"
test_run "test_oval_details_rpminfo_object_explicit" test_oval_details_explicit
rpminfo "name.*release.*version" "rpm"
if ! pidof systemd > /dev/null ; then
test_run "test_oval_details_runlevel_object_implicit"
test_oval_details_implicit runlevel "service name.*runlevel" "smartd"
test_run "test_oval_details_runlevel_object_explicit"
test_oval_details_explicit runlevel "service name.*runlevel" "smartd"
path:
openscap_1.4.3+dfsg-1/tests/probes/systemdunitproperty/test_probes_systemdunitproperty_offline_mode.sh
probecheck "systemdunitproperty" || return 255
pidof systemd > /dev/null || return 255
local ret_val=0;
path:
openscap_1.4.3+dfsg-1/tests/probes/systemdunitproperty/test_probes_systemdunitproperty.sh
function test_probes_systemdunitproperty {
probecheck "systemdunitproperty" || return 255
pidof systemd > /dev/null || return 255
systemctl > /dev/null 2>&1 || return 255
path:
openscap_1.4.3+dfsg-1/tests/probes/systemdunitdependency/test_probes_systemdunitdependency_offline_mode.sh
probecheck "systemdunitdependency" || return 255
pidof systemd > /dev/null || return 255
local ret_val=0;
path:
openscap_1.4.3+dfsg-1/tests/probes/systemdunitproperty/test_probes_systemdunitproperty_mount_wants.sh
function test_probes_systemdunitproperty_mount_wants {
probecheck "systemdunitproperty" || return 255
pidof systemd > /dev/null || return 255
systemctl show -- -.mount | grep -Eq "Wants=\S+" || return 255
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
