Source: plasma-desktop
Version: 4:6.6.4-1
Usertags: pidof-without-procps
Dear maintainer(s) of plasma-desktop,
it appears that plasma-desktop uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of plasma-desktop
that use `pidof` at runtime;
* via the `Build-Depends:` field of plasma-desktop, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of plasma-desktop, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that plasma-desktop uses `pidof` due to the following
code snippets:
```
path: plasma-desktop_4:6.5.4-2/appiumtests/desktop/folderviewtest.py
if __name__ == '__main__':
assert subprocess.call(["pidof", "plasmashell"]) != 0, "The test requires
plasmashell to quit"
unittest.main()
path: plasma-desktop_4:6.5.4-2/appiumtests/applets/taskmanagertest.py
for _ in range(10):
try:
subprocess.check_call(["pidof", "plasmawindowed"])
except subprocess.CalledProcessError:
break
path: plasma-desktop_4:6.5.4-2/appiumtests/desktop/bug472909.py
if __name__ == '__main__':
assert subprocess.call(["pidof", "plasmashell"]) != 0, "The test requires
plasmashell to quit"
unittest.main()
path: plasma-desktop_4:6.5.4-2/appiumtests/desktop/panelfocustest.py
if __name__ == '__main__':
assert subprocess.call(["pidof", "plasmashell"]) != 0, "The test requires
plasmashell to quit"
unittest.main()
path: plasma-desktop_4:6.5.4-2/appiumtests/desktop/bug476968.py
if __name__ == '__main__':
assert subprocess.call(["pidof", "plasmashell"]) != 0, "The test requires
plasmashell to quit"
unittest.main()
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
