Source: plasma-workspace
Version: 4:6.6.4-1
Usertags: pidof-without-procps

Dear maintainer(s) of plasma-workspace,

it appears that plasma-workspace uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of plasma-workspace
  that use `pidof` at runtime;
* via the `Build-Depends:` field of plasma-workspace, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of plasma-workspace, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that plasma-workspace uses `pidof` due to the following
code snippets:

```
path: plasma-workspace_4:6.5.4-3/appiumtests/applets/cameraindicatortest.py
        cls.driver = 
webdriver.Remote(command_executor=f'http://127.0.0.1:{os.getenv("FLASK_PORT", 
"4723")}', options=options)
        cls.pipewire_already_running_before_test = subprocess.Popen(["pidof", 
"pipewire"]).wait() == 0
    def tearDown(self) -> None:


path: plasma-workspace_4:6.5.4-3/appiumtests/applets/notificationstest.py
if __name__ == '__main__':
    assert "USE_CUSTOM_BUS" in os.environ or subprocess.call(["pidof", 
"plasmashell"]) != 0 or "KDECI_BUILD" in os.environ, "plasmashell should not be 
running"
    logging.getLogger().setLevel(logging.INFO)
    unittest.main(failfast=True)


path: plasma-workspace_4:6.5.4-3/appiumtests/applets/clipboardtest.py
if __name__ == '__main__':
    assert subprocess.call(["pidof", "plasmashell"]) != 0, "The test requires 
plasmashell to quit"
    assert os.getenv("GDK_BACKEND") == "wayland", "The test requires wayland 
GDK_BACKEND"
    assert os.getenv("QT_QPA_PLATFORM") == "wayland", "The test requires 
wayland QT_QPA_PLATFORM"
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to