Source: psychtoolbox-3
Version: 3.0.19.14.dfsg1-1
Usertags: pidof-without-procps
Dear maintainer(s) of psychtoolbox-3,
it appears that psychtoolbox-3 uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of psychtoolbox-3
that use `pidof` at runtime;
* via the `Build-Depends:` field of psychtoolbox-3, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of psychtoolbox-3, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that psychtoolbox-3 uses `pidof` due to the following
code snippets:
```
path:
psychtoolbox-3_3.0.19.14.dfsg1-1/Psychtoolbox/PsychHardware/PsychVRToolbox/PsychOpenXR.m
% Does the metrics fifo file exist at the expected location? And
monado-service is running?
monadometricsfile = getenv('XRT_METRICS_FILE');
[rc, ~] = system('pidof monado-service');
if exist(monadometricsfile, 'file') && (rc == 0)
% Yes. Try to open it. monado-service must have been launched with proper
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
