Source: qtvirtualkeyboard-opensource-src
Version: 5.15.17+dfsg-2
Usertags: pidof-without-procps

Dear maintainer(s) of qtvirtualkeyboard-opensource-src,

it appears that qtvirtualkeyboard-opensource-src uses `pidof` in its testsuite, 
or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of 
qtvirtualkeyboard-opensource-src
  that use `pidof` at runtime;
* via the `Build-Depends:` field of qtvirtualkeyboard-opensource-src, if 
`pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of qtvirtualkeyboard-opensource-src, please 
add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that qtvirtualkeyboard-opensource-src uses `pidof` due to the 
following
code snippets:

```
path: 
qtvirtualkeyboard-opensource-src_5.15.17+dfsg-2/tests/manual/x11vkbwrapper/handleatspievents.cpp
    /** Check that At-spi is running */
    if (KProsessIsRunning != system(QString("pidof -x %1 > 
/dev/null").arg(KAtspiBusLauncher).toLatin1().data()) ||
            KProsessIsRunning != system(QString("pidof -x %1 > 
/dev/null").arg(KAtspiRegistryd).toLatin1().data())) {
        qWarning() << "One or both of the At-Spi related processes are not 
running.";
        return false;
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to