Source: runit
Version: 2.3.1-3
Usertags: pidof-without-procps
Dear maintainer(s) of runit,
it appears that runit uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of runit
that use `pidof` at runtime;
* via the `Build-Depends:` field of runit, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of runit, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that runit uses `pidof` due to the following
code snippets:
```
path: runit_2.3.0-1/debian/contrib/lib/trigger_sv
# fi
# done
if [ -f /etc/runit/stopit ] && pidof runsvdir > /dev/null ; then
[ "$(id -u)" = 0 ] && kill -s ALRM 1 # force rescan to pick
changes in enabled/disabled service status
fi
path: runit_2.3.0-1/debian/contrib/lib/trigger_sv
echo "$defaultdir : directory not found, exit" && exit 1
fi
if [ ! -f /etc/runit/stopit ] && ! pidof -q runsvdir ; then
[ -e /etc/runit/verbose ] && echo "no runsvdir found, exit"
exit 0 # noop if runit is not init and there's no runsvdir
running
path: runit_2.3.0-1/debian/tests/init-switch
if pidof getty; then
echo "OK"
elif pidof fgetty; then
echo "OK"
else
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
