Source: runit-services
Version: 0.12.0
Usertags: pidof-without-procps
Dear maintainer(s) of runit-services,
it appears that runit-services uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of runit-services
that use `pidof` at runtime;
* via the `Build-Depends:` field of runit-services, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of runit-services, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that runit-services uses `pidof` due to the following
code snippets:
```
path: runit-services_0.11.0/debian/tests/services-test.sh
sleep 7
[ -e /etc/service/.forced-rescan ] && echo " forced rescan done "
pidof runsvdir || true
echo "pstree output" && pstree
path: runit-services_0.11.0/debian/tests/services-test.sh
nfailed=1
fi
pidof runsvdir || true
[ ! -e /etc/service/.forced-rescan ] && echo " no forced rescan so far"
systemctl kill -s 14 runit.service # SIGALRM to force rescan
path: runit-services_0.11.0/debian/tests/services-test.sh
nfailed=0
pidof systemd || echo "systemd not running"
if ! systemctl status runit.service ; then
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
