Source: smbldap-tools Version: 0.9.11-3 Usertags: pidof-without-procps Dear maintainer(s) of smbldap-tools,
it appears that smbldap-tools uses `pidof` in its testsuite, or that at least one of its binary packages uses `pidof` at runtime. Historically, `pidof` was provided by the Essential package `sysvinit-tools`, making an explicit dependency unnecessary. However `pidof` will soon be moved to `procps` and will no longer be part of the Essential set. Please add an explicit dependency on `procps`: * via the `Depends:` field of all binary packages of smbldap-tools that use `pidof` at runtime; * via the `Build-Depends:` field of smbldap-tools, if `pidof` is used in tests run at build-time; * via the `Depends:` field of `debian/control/tests`, if `pidof` is used in autopkgtests. To prevent any disruption for users of smbldap-tools, please add this dependency now, before `pidof` is moved from `sysvinit-utils` to `procps`. Alternatively, you could remove all uses of `pidof`. It is believed that smbldap-tools uses `pidof` due to the following code snippets: ``` path: smbldap-tools_0.9.11-3/smbldap-config.pl # we first check if Samba is up and running my $test_smb=`pidof smbd`; chomp($test_smb); die "\nSamba needs to be started first !\n" if ($test_smb eq "" || not defined $test_smb); ``` Feel free to close this issue if this is a false positive (for example if this code is in an unreachable code path). Regards, -- Gioele Barabucci
