Source: stopmotion
Version: 0.9.0-2
Usertags: pidof-without-procps

Dear maintainer(s) of stopmotion,

it appears that stopmotion uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of stopmotion
  that use `pidof` at runtime;
* via the `Build-Depends:` field of stopmotion, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of stopmotion, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that stopmotion uses `pidof` due to the following
code snippets:

```
path: stopmotion_0.9.0-2/src/presentation/frontends/qtfrontend/qtfrontend.cpp
                        "--every 25 $IMAGEFILE &");
        prefs->setPreference("importstopdaemon4",
                        "kill -2 $(pidof dvgrab)");
        // 
-----------------------------------------------------------------------


path: stopmotion_0.9.0-2/src/presentation/frontends/qtfrontend/qtfrontend.cpp
                        "vgrabbj -f $IMAGEFILE -d $VIDEODEVICE -b -D 0 -i vga 
-L250000");
        prefs->setPreference("importstopdaemon1",
                        "kill $(pidof vgrabbj)");
        // Default import option 3
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to