Source: tightvnc
Version: 1:1.3.10-10
Usertags: pidof-without-procps
Dear maintainer(s) of tightvnc,
it appears that tightvnc uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of tightvnc
that use `pidof` at runtime;
* via the `Build-Depends:` field of tightvnc, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of tightvnc, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that tightvnc uses `pidof` due to the following
code snippets:
```
path: tightvnc_1:1.3.10-10/Xvnc/lib/font/fc/Makefile
transport.o: transport.c
if ! $(CC) -c $(CPPFLAGS) $(CFLAGS) -Wno-error=format-security
$(XTRANS_INCS) $(DEFS) $(XTRANS_DEFS) -o $@ $< ; then kill -s TERM `pidof make`
; fi
transport.c: ../../xtrans/transport.c
path: tightvnc_1:1.3.10-10/debian/tests/test-vnc-connection.d/stop-vnc-client
set -e
kill `pidof vncviewer`
sleep 2
path: tightvnc_1:1.3.10-10/debian/patches/install-makefile-build-system.patch
+
+transport.o: transport.c
+ if ! $(CC) -c $(CPPFLAGS) $(CFLAGS) -Wno-error=format-security
$(XTRANS_INCS) $(DEFS) $(XTRANS_DEFS) -o $@ $< ; then kill -s TERM `pidof make`
; fi
+
+transport.c: ../../xtrans/transport.c
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
