Source: uwsgi
Version: 2.0.31-4
Usertags: pidof-without-procps
Dear maintainer(s) of uwsgi,
it appears that uwsgi uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of uwsgi
that use `pidof` at runtime;
* via the `Build-Depends:` field of uwsgi, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of uwsgi, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that uwsgi uses `pidof` due to the following
code snippets:
```
path: uwsgi_2.0.31-3/tests/gh-shared.sh
date > reload.txt
sleep 3
pidof uwsgi && killall uwsgi
sleep 1
pidof uwsgi && killall -9 uwsgi
path: uwsgi_2.0.31-3/tests/gh-shared.sh
http_test() {
URL=$1
UPID=`pidof uwsgi`
if [ "$UPID" != "" ]; then
echo -e "${bldgre}>>> Spawned PID $UPID, running tests${txtrst}"
path: uwsgi_2.0.31-3/tests/gh-shared.sh
pidof uwsgi && killall uwsgi
sleep 1
pidof uwsgi && killall -9 uwsgi
echo -e "$@"
if [ -e uwsgi.log ]; then
path: uwsgi_2.0.31-3/tests/travis.sh
date > reload.txt
sleep 3
pidof uwsgi && killall uwsgi
sleep 1
pidof uwsgi && killall -9 uwsgi
path: uwsgi_2.0.31-3/tests/travis.sh
http_test() {
URL=$1
UPID=`pidof uwsgi`
if [ "$UPID" != "" ]; then
echo -e "${bldgre}>>> Spawned PID $UPID, running tests${txtrst}"
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
