Source: variety
Version: 0.9.0-1
Usertags: pidof-without-procps
Dear maintainer(s) of variety,
it appears that variety uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of variety
that use `pidof` at runtime;
* via the `Build-Depends:` field of variety, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of variety, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that variety uses `pidof` due to the following
code snippets:
```
path: variety_0.9.0~b1-2/variety/data/scripts/set_wallpaper
# Grey background flicker is prevented by killing old swaybg process
after new one.
# See https://github.com/swaywm/swaybg/issues/17#issuecomment-851680720
PID=$(pidof swaybg)
swaybg -i "$WP" -m fill &
if [ -n "$PID" ]; then
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
