Tommi Höynälänmaa <[email protected]> writes: > Hello > > I have uploaded Guile Fluidsynth to Salsa. I have to wait for nyacc to > be updated in Debian unstable before I can upload Guile Fluidsynth to > Debian unstable. See > <https://salsa.debian.org/scheme-team/guile-fluidsynth>.
Welcome to the team! Quick review: - Add d/upstream/metadata - Send d/patches/ upstream, and mark them as Forwarded. - Fix licenserecon warnings about d/copyright -- there are many copyright notices in the sources not present in d/copyright. - Is it possible to write some non-superficial debian/tests/? Based on the manual maybe? Upstream really ought to have a test-suite as part of 'make check', so maybe ask upstream. - Use d/watch v5 - upstream signs git tags, so I suggest adding a d/upstream/signing-key.asc and using a debian/watch like this: Version: 5 Source: https://https.git.savannah.gnu.org/git/guile-fluidsynth.git Matching-Pattern: refs/tags/v@ANY_VERSION@ Mode: git Pgpmode: gittag - Update Standards-Version, dropping Priority and Rules-Requires-Root. - I see no need for a versioned dependency on texinfo in d/control. - What is the purpose of this in debian/rules? export DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH) - Consider adding sign-tags=True and upstream-vcs-tag = v%(version%~%-)s to debian/gbp.conf. /Simon
signature.asc
Description: PGP signature
