On Mon, 1 Jun 2026 22:20:56 +0200 Santiago Vila <[email protected]> wrote:
> On Mon, Jun 01, 2026 at 04:06:26PM -0400, Grayson Wolf wrote:
>
> -       chown list:list $(DESTDIR)/var/lib/quickml
> -       chown list:list $(DESTDIR)/var/log/quickml
>
> Hi. I don't think this is correct.
>
> The intent is for those directories to be list:list inside the .deb,
> and a postinst can't change what is inside the .deb.
>
> The orthodox fix here is to use "Rules-Requires-Root: binary-targets"
>
> (If there is a build failure, it's because "no" has become the default,
> but maintainers can still use a value different than "no").
>
> Thanks.
>
>

Hi, thank you for the feedback. I've adjusted the patch accordingly.

Thanks.
diff --git a/debian/control b/debian/control
index cc5139d..80aeb87 100644
--- a/debian/control
+++ b/debian/control
@@ -5,6 +5,7 @@ Maintainer: Benda Xu <[email protected]>
 Build-Depends: debhelper-compat (= 13)
 Build-Depends-Indep: ruby, ruby-dev
 Standards-Version: 4.5.0
+Rules-Requires-Root: binary-targets
 
 Package: quickml
 Architecture: all
diff --git a/debian/patches/0001-Upstream-all-the-debian-patches.patch b/debian/patches/0001-Upstream-all-the-debian-patches.patch
index 8222a6a..ca5885e 100644
--- a/debian/patches/0001-Upstream-all-the-debian-patches.patch
+++ b/debian/patches/0001-Upstream-all-the-debian-patches.patch
@@ -5,7 +5,6 @@ Subject: Upstream all the debian patches.
 ---
  lib/quickml/core.rb    | 1 +
  lib/quickml/gettext.rb | 1 +
- messages.ja            | 1 +
  3 files changed, 3 insertions(+)
 
 diff --git a/lib/quickml/core.rb b/lib/quickml/core.rb
@@ -26,12 +25,3 @@ index 09ae558..700929a 100644
  #
  # quickml/gettext - a part of quickml server
  #
-diff --git a/messages.ja b/messages.ja
-index a99af25..b91d47f 100644
---- a/messages.ja
-+++ b/messages.ja
-@@ -1,3 +1,4 @@
-+# coding: euc-jp
- # -*- mode: ruby -*-
- Messages = {
-   "<%s> was removed from the mailing list:\n<%s>\n" =>

Reply via email to