On Sat, Jun 06, 2026 at 12:41:51PM +0200, Santiago Vila wrote: > On Sat, Jun 06, 2026 at 12:57:34PM +0300, Adrian Bunk wrote: > > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -237,7 +237,7 @@ AS_IF([test "x$with_ssl" != xno], [ > > > > > > # Add Gettext > > > AM_GNU_GETTEXT([external]) > > > -AM_GNU_GETTEXT_VERSION([0.11.1]) > > > +AM_GNU_GETTEXT_VERSION([0.23]) > > >... > > > > There is a major difference between what Debian wants and what > > autopoint does. > > > > "autopoint --force" does *not* copy the gettext files from the latest > > gettext version, it copies the files from the exact gettext version > > in AM_GNU_GETTEXT_VERSION. > > > > E.g. AM_GNU_GETTEXT_VERSION([0.11.4]) also fixes the build since that's > > when AM_GNU_GETTEXT_VERSION was added to gettext.m4, but the package > > will be built with the gettext files from 0.11.4 (released in 2002). > > > > This happened to work with older gettext versions where the gettext > > m4 macros were shipped in the global search path. > > > > Omitting AM_GNU_GETTEXT_VERSION works, but uses the files from 0.23.1 > > (not the current version 0.26). > > > > The first question is whether this behaviour is wanted in Debian, > > or whether Debian package builds should use the latest version. > > For the proposed patch, I decided to update the version a little bit, > after checking that it works, while still allowing builds in trixie. > That's all.
If upstream would add a gh pipeline that includes Ubuntu 24.04, then your suggestion of using that version upstream would break. AM_GNU_GETTEXT_REQUIRE_VERSION([0.19.6]) would be better for that, since it permits using the latest version without breaking the build in older environments.[1] > No, there is no need to use the latest version. Lots of upstream > packages have a version in AM_GNU_GETTEXT_VERSION which is a lot > older than our stable distribution and they work fine. >... Few packages have been rebuilt with 0.26 so far. Building packaged axel in trixie uses 0.23, building packaged axel in sid uses 0.11.1. A package with AM_GNU_GETTEXT_VERSION([0.11.4]) might use 22 year older macros in forky than in trixie. What happens when something like the C23 default change in GCC 15 breaks a > 20 year old gettext macro? This class of problems is part of the rationale for dh-autoreconf updating everything. > Thanks. cu Adrian [1] AM_GNU_GETTEXT_REQUIRE_VERSION was added in 0.19.6
