Source: fritzing
Version: 1.0.1-1.1
Severity: serious
Justification: ftbfs
Tags: ftbfs patch
Control: block 1138499 by -1

Dear Maintainer,

Your package fails to build from source with the new libquazip1 version 1.7.1, because it contains a patch that hard-codes version 1.5 in the build script. I have attached a patch that bumps it to target 1.7.1; I would advise you to try and find an alternative way to patch the source such that it does not target a specific version of QuaZip, so this does not happen with every future new version.

Regards
--
Ben Westover
diff --git a/debian/patches/other-libraries.patch b/debian/patches/other-libraries.patch
index 9333f3f..a079b3b 100644
--- a/debian/patches/other-libraries.patch
+++ b/debian/patches/other-libraries.patch
@@ -33,10 +33,10 @@ Index: fritzing/pri/quazipdetect.pri
  
 -exists($$absolute_path($$PWD/../../quazip_qt$$QT_MAJOR_VERSION)) {
 -        QUAZIPPATH = $$absolute_path($$PWD/../../quazip_qt$$QT_MAJOR_VERSION)
-+exists(/usr/include/QuaZip-Qt5-1.5) {
++exists(/usr/include/QuaZip-Qt5-1.7.1) {
 +        ## QUAZIPPATH = $$absolute_path($$PWD/../../quazip_qt$$QT_MAJOR_VERSION)
 +	# in Debian, the package libquazip1-qt5-dev provides:
-+	QUAZIPPATH = /usr/include/QuaZip-Qt5-1.5/quazip
++	QUAZIPPATH = /usr/include/QuaZip-Qt5-1.7.1/quazip
          message("found quazip in $${QUAZIPPATH}")
      } else {
          error("quazip could not be found.")

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to