tags 1046450 patch
severity 1046450 normal
thanks

On Sun, Jun 07, 2026 at 04:20:22PM +0200, Paul Gevers wrote:

> Because control messages typically (your case below is a very good
> exception) contain too little information I filter them away. If you have a
> message, you should cc <package>@packages.debian.org in my opinion. I
> completely missed that you reopened this bug report. Given that there were 3
> years between closing and reopening, it's also very well possible that it's
> a *new* bug. I think it's safer to file a *new* report in cases like this,
> unless you show that the upload closing the bug was flawed (I don't think
> that's worth the effort, a new bug just works fine).

Hi. This was a one-time thing and there are several reasons why I
decided to reopen instead of filing new bugs:

- dpkg-source showed the extra files using the directory as a prefix,
some people just copied and pasted that into debian/clean and called
it a day, without realizing that the bug was still there.

- dpkg-source very often did not show all the problems but only some
of them. As a result, just copying and pasting the files into
debian/clean (this time removing the extra prefix) might still keep
the issue unfixed.

The above two items are #1126558 and #1126665 (which I mentioned in
the bug reopening message). Because of those two bugs, the probability
that the bug was closed improperly was quite high.

- Also: I did not like at all the idea of filing a lot of new bugs for this,
at least at such point.

For all the above reasons I decided to reopen the old bugs.

But as I said, this was a one-time thing. Now that dpkg-source has
been fixed, if I ever decide to report a lot of bugs, they would be
certainly new bugs.

(For the currently open bugs, I am monitoring them weekly, and I usually
know well enough when they are closed improperly or not. Since this happen
sparsely, I can also offer a patch most of the time when I reopen them).


BTW: This is the way this package fails currently:

dpkg-source: info: local changes detected, the modified files are:
 js/item.xml
 js/node.xml

and I believe the attached patch should fix the issue
(but please double-check).

Thanks.
commit a316ef83caf4eed2fa3d7e9a20b144897fb652c3
Author: Santiago Vila <[email protected]>
Date:   Sun Jun 7 17:02:00 2026 +0200

    Fix clean target. Closes: #1046450.

diff --git a/debian/clean b/debian/clean
index 006744b..b003e57 100644
--- a/debian/clean
+++ b/debian/clean
@@ -1,4 +1,6 @@
 config.log
+js/item.xml
+js/node.xml
 js/vendor/handlebars.min.js
 js/vendor/purify.min.js
 net.sf.liferea.gschema.xml

Reply via email to