Jeroen Ploemen <[email protected]> writes: > On Tue, 09 Jun 2026 19:02:53 +0200 > Simon Josefsson <[email protected]> wrote: > >> Review of this packaging would be appreciated. > > Most of the upstream testsuite makes use of gen_schemas, which does > not appear to have been packaged in Debian. As a result, no tests are > run on build and 'Testsuite: autopkgtest-pkg-pybuild' should not be > used: all that does under these circumstances is pretend the package > comes with an autopkgtest. Try autopkgtest-pkg--python instead.
Thank you for looking at the package! I didn't know about the various python testsuite options. I changed to use autopkgtest-pkg-python now. For future reference, I found explanation of autopkgtest-pkg-pybuild vs autopkgtest-pkg-python here: https://manpages.debian.org/testing/autodep8/autodep8.1.en.html#EXAMPLES_OF_PRODUCED_TEST_CONTROL_FILES I have uploaded this to NEW queue. >> I considered using github instead of pypi tarballs, but it seems >> upstream doesn't push tags to github so figuring which commits to >> pin to and writing the watch file seems complicated... reported as >> https://github.com/python-jsonschema/hypothesis-jsonschema/issues/113 > > You are free to use whichever best suits your needs, there's no team > policy that requires or even prefers one over the other. Usually, it > boils down to the one that includes tests and documentation. Okay. My own preference is now to to use git sources directly. But for this package, understanding which git commit they used for each release seems complicated since they don't publish git tags. And writing a debian/watch for this situation seems impossible. I suspect this isn't intentional by upstream, just some artifact of their workflow (the homepage URL on pypi.org also seems odd... [1]), so this could all be clarified whenever upstream responds. /Simon [1] https://github.com/python-jsonschema/hypothesis-jsonschema/issues/114
signature.asc
Description: PGP signature
