Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: [email protected], [email protected]
Control: affects -1 + src:ojalgo
User: [email protected]
Usertags: pu

[ Reason ]
Bug #1037435. Some tests try to use the network.
Also, we need to disable some tests as flaky.

[ Impact ]
Package FTBFS 100% of the time when built using the schroot backend
of sbuild, which was the default in bookworm.

[ Tests ]
I've tested that the package builds ok again. I've also tested
that the failure rate after disabling flaky tests has been
greatly reduced.

[ Risks ]
Very low. No code changes. Some tests are disabled and some other
tests have a relaxed threshold so that they do not fail so easily.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
Disable all tests that tried to use the network.
Disable some tests as flaky, backporting the fix from trixie.

[ Other info ]
Package is already uploaded.
diff -Nru ojalgo-52.0.1+ds/debian/changelog ojalgo-52.0.1+ds/debian/changelog
--- ojalgo-52.0.1+ds/debian/changelog   2023-01-18 23:27:34.000000000 +0100
+++ ojalgo-52.0.1+ds/debian/changelog   2026-06-26 22:30:00.000000000 +0200
@@ -1,3 +1,15 @@
+ojalgo (52.0.1+ds-1+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+
+  [ Pierre Gruet ]
+  * Disable more tests requiring network access. Closes: #1037435.
+
+  [ Santiago Vila ]
+  * Apply some fixes from trixie.
+
+ -- Santiago Vila <[email protected]>  Fri, 26 Jun 2026 22:30:00 +0200
+
 ojalgo (52.0.1+ds-1) unstable; urgency=medium
 
   * New upstream version 52.0.1+ds
diff -Nru ojalgo-52.0.1+ds/debian/patches/fixes-from-trixie.patch 
ojalgo-52.0.1+ds/debian/patches/fixes-from-trixie.patch
--- ojalgo-52.0.1+ds/debian/patches/fixes-from-trixie.patch     1970-01-01 
01:00:00.000000000 +0100
+++ ojalgo-52.0.1+ds/debian/patches/fixes-from-trixie.patch     2026-06-26 
21:06:00.000000000 +0200
@@ -0,0 +1,68 @@
+Description: Apply some fixes from trixie
+Author: Santiago Vila <[email protected]>
+Forwarded: not-needed
+Last-Update: 2026-06-26
+
+--- a/src/test/java/org/ojalgo/random/RandomNumberTest.java
++++ b/src/test/java/org/ojalgo/random/RandomNumberTest.java
+@@ -24,6 +24,7 @@
+ import static org.ojalgo.function.constant.PrimitiveMath.*;
+ 
+ import org.junit.jupiter.api.Disabled;
++import org.junit.jupiter.api.Tag;
+ import org.junit.jupiter.api.Test;
+ import org.ojalgo.TestUtils;
+ import org.ojalgo.array.ArrayR064;
+@@ -261,6 +262,7 @@
+     }
+ 
+     @Test
++    @Tag("unstable")
+     public void testGamma() {
+         // TODO 15% error seems a little high
+         this.testDist2(new Dist2Gamma(), new double[] { .01, .01 }, new 
double[] { 10, 10 }, new double[] { 100, 100 }, 200000, .15);
+@@ -392,6 +394,7 @@
+     }
+ 
+     @Test
++    @Tag("unstable")
+     public void testSampledMean() {
+ 
+         RandomNumber[] tmpRndNmbrs = { new Exponential(), new LogNormal(), 
new Normal(), new Uniform(), new Binomial(), new Geometric(), new Poisson(),
+@@ -454,6 +457,7 @@
+     }
+ 
+     @Test
++    @Tag("unstable")
+     public void testVariance() {
+ 
+         double tmpStdDev = TEN;
+--- a/src/test/java/org/ojalgo/tensor/TensorTest.java
++++ b/src/test/java/org/ojalgo/tensor/TensorTest.java
+@@ -21,6 +21,7 @@
+  */
+ package org.ojalgo.tensor;
+ 
++import org.junit.jupiter.api.Tag;
+ import org.junit.jupiter.api.Test;
+ import org.ojalgo.TestUtils;
+ import org.ojalgo.array.ArrayAnyD;
+@@ -144,6 +145,7 @@
+     }
+ 
+     @Test
++    @Tag("unstable")
+     public void testDeterminantAndTrace() {
+ 
+         MatrixTensor<RationalNumber> tensorA = FACTORY_2.copy(ELEMENTS_A);
+--- a/src/test/java/org/ojalgo/TestUtils.java
++++ b/src/test/java/org/ojalgo/TestUtils.java
+@@ -70,7 +70,7 @@
+  */
+ public abstract class TestUtils /* extends Assertions */ {
+ 
+-    private static final NumberContext EQUALS = NumberContext.of(12, 14);
++    private static final NumberContext EQUALS = NumberContext.of(10);
+ 
+     public static void assertBounds(final Comparable<?> lower, final 
Access1D<?> values, final Comparable<?> upper, final NumberContext precision) {
+         for (ElementView1D<?, ?> tmpValue : values.elements()) {
diff -Nru ojalgo-52.0.1+ds/debian/patches/no_network_tests.patch 
ojalgo-52.0.1+ds/debian/patches/no_network_tests.patch
--- ojalgo-52.0.1+ds/debian/patches/no_network_tests.patch      2023-01-18 
22:33:30.000000000 +0100
+++ ojalgo-52.0.1+ds/debian/patches/no_network_tests.patch      2026-06-26 
21:05:00.000000000 +0200
@@ -22,3 +22,39 @@
  public class AlphaVantageDataSourceTest extends FinanceSeriesTests {
  
      public AlphaVantageDataSourceTest() {
+--- 
a/src/test/java/org/ojalgo/data/domain/finance/series/YahooDataSourceTest.java
++++ 
b/src/test/java/org/ojalgo/data/domain/finance/series/YahooDataSourceTest.java
+@@ -22,6 +22,7 @@
+  */
+ package org.ojalgo.data.domain.finance.series;
+ 
++import org.junit.jupiter.api.Disabled;
+ import org.junit.jupiter.api.Test;
+ import org.ojalgo.TestUtils;
+ import org.ojalgo.type.CalendarDateUnit;
+@@ -31,6 +32,7 @@
+  *
+  * @author apete
+  */
++@Disabled("Requires network access")
+ public class YahooDataSourceTest extends FinanceSeriesTests {
+ 
+     private static YahooSession SESSION = new YahooSession();
+--- 
a/src/test/java/org/ojalgo/optimisation/service/OptimisationServiceTest.java
++++ 
b/src/test/java/org/ojalgo/optimisation/service/OptimisationServiceTest.java
+@@ -1,6 +1,7 @@
+ package org.ojalgo.optimisation.service;
+ 
+ import org.junit.jupiter.api.AfterEach;
++import org.junit.jupiter.api.Disabled;
+ import org.junit.jupiter.api.Test;
+ import org.ojalgo.TestUtils;
+ import org.ojalgo.netio.BasicLogger;
+@@ -9,6 +10,7 @@
+ import org.ojalgo.optimisation.ExpressionsBasedModel;
+ import org.ojalgo.optimisation.Optimisation.Result;
+ 
++@Disabled("Requires network access")
+ public class OptimisationServiceTest {
+ 
+     private static final String PATH_ENVIRONMENT = 
"/optimisation/v01/environment";
diff -Nru ojalgo-52.0.1+ds/debian/patches/series 
ojalgo-52.0.1+ds/debian/patches/series
--- ojalgo-52.0.1+ds/debian/patches/series      2023-01-18 22:32:05.000000000 
+0100
+++ ojalgo-52.0.1+ds/debian/patches/series      2026-06-26 21:00:00.000000000 
+0200
@@ -3,3 +3,4 @@
 relax_time_limit.patch
 omitting_random_assertion_failure.patch
 no_network_tests.patch
+fixes-from-trixie.patch
diff -Nru ojalgo-52.0.1+ds/debian/salsa-ci.yml 
ojalgo-52.0.1+ds/debian/salsa-ci.yml
--- ojalgo-52.0.1+ds/debian/salsa-ci.yml        2021-10-17 10:06:03.000000000 
+0200
+++ ojalgo-52.0.1+ds/debian/salsa-ci.yml        2026-06-26 21:00:00.000000000 
+0200
@@ -1,17 +1,10 @@
 ---
 include:
-  - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
-  - 
https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+  - 
https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/recipes/debian.yml
 
-# To exclude single tests you can use
-#variables:
-#  SALSA_CI_DISABLE_APTLY: 1
-#  SALSA_CI_DISABLE_AUTOPKGTEST: 1
-#  SALSA_CI_DISABLE_BLHC: 1
-#  SALSA_CI_DISABLE_LINTIAN: 1
-#  SALSA_CI_DISABLE_PIUPARTS: 1
-#  SALSA_CI_DISABLE_REPROTEST: 1
-#  SALSA_CI_DISABLE_BUILD_PACKAGE_ALL: 1
-#  SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 1
-# In case for instance i386 is explicitly excluded by Build-Depends
-#  SALSA_CI_DISABLE_BUILD_PACKAGE_I386: 1
+variables:
+  SALSA_CI_DISABLE_BUILD_PACKAGE_I386: 1
+  SALSA_CI_DISABLE_BUILD_PACKAGE_ALL: 1
+  SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 1
+  SALSA_CI_DISABLE_DEBREBUILD: 1
+  SALSA_CI_DISABLE_USCAN: 1

Reply via email to