Source: popplerkit.framework Version: 0.0.20051227svn-17 Severity: normal Tags: ftbfs patch
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Dear Maintainer, popplerkit.framework will FTBFS once poppler >= 26.02 reaches the archive (unstable currently ships 26.01). poppler 26.02 removed the reverseVideo parameter from the SplashOutputDev constructor, so the call in bindings/poppler_splash_renderer.cc no longer matches: ``` poppler_splash_renderer.cc:46:79: error: no matching function for call to 'SplashOutputDev::SplashOutputDev(SplashColorMode, int, bool, SplashColor)' ``` The version guard makes the code change a no-op on the current poppler (26.01), the added libpoppler-cpp-dev build-dep already exists in Debian and only provides poppler/cpp/poppler-version.h. The debdiff is therefore safe to apply now, ahead of the transition Thanks, Nadzeya -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEuVOE/FJ0HcdfWSw//lAdKwFeZPsFAmpgpc4ACgkQ/lAdKwFe ZPug0A/+I00368fiRYWgR0JFNq4/2DeSLJOaA98zqXfRuwDGBYMZ7ihXFD4gUq4x LeDXhwS61MLq67t9TjljpwrFoK0SzJDAbofvtnl8Arje6tX+g8J+qHwR2+gCGoJy s91tXIMSCkBF0KCQ5jyMePdIg3Hykp+Xq1EW2LGs/gc6q23nWhIwyiL/a67hLU2n C1SBZMkGJJPSY7yROz5DbUn4l9ovIM37H/Jw+iF8xKU2LWal+cLJQQVCWhZmCmDj Zwm+Jw9qeTRtm6Tdd/LtwQbS6FT3PPE2nBREs3ca3gAc/bZoyWNlWGlJlECKKa4V piKzOCx/04Y1HjFeH8bSp1yuPU/pMZdrZgmWpgpTN/oloaf0sHWnoj67OBzdbaXM nCkFlzxACb0a82yjr2++AqOE7dj1Jepx0TTwR2SGfNmdbX4wRrD236+U5DD9cSe9 e0CJAsO8SB615WW8Np/mnm45eLgLrMaXNSJYvOl3R5csEF7hOyWIFTJJK1ipUBH/ FOkSy2gCPVrdgucZI5edp2S1Sg0Cwwn+4DAuzJAr+o55o5AGPBB1/FH4+sL+6Xe/ 6+zqyoVzO4kUgOAyRfMJ3fH0QzLvKoi9TOJkCD71s4ATmMX7QiA/4/Xj/JCjJu8d gUnw2uJKCQw0uL+sZYpcprIQZ8jVz48tpJCB6MIRIWuBU0eu26w= =ri+t -----END PGP SIGNATURE-----
diff -Nru popplerkit.framework-0.0.20051227svn/debian/control popplerkit.framework-0.0.20051227svn/debian/control --- popplerkit.framework-0.0.20051227svn/debian/control 2025-09-14 07:38:08.000000000 +0200 +++ popplerkit.framework-0.0.20051227svn/debian/control 2026-07-22 12:58:49.000000000 +0200 @@ -9,6 +9,7 @@ libfontconfig-dev, libfreetype-dev, libgnustep-gui-dev (>= 0.32), + libpoppler-cpp-dev, libpoppler-private-dev, pkgconf, Vcs-Git: https://salsa.debian.org/gnustep-team/popplerkit.git diff -Nru popplerkit.framework-0.0.20051227svn/debian/patches/poppler2602.patch popplerkit.framework-0.0.20051227svn/debian/patches/poppler2602.patch --- popplerkit.framework-0.0.20051227svn/debian/patches/poppler2602.patch 1970-01-01 01:00:00.000000000 +0100 +++ popplerkit.framework-0.0.20051227svn/debian/patches/poppler2602.patch 2026-07-22 12:58:49.000000000 +0200 @@ -0,0 +1,32 @@ +Description: Fix FTBFS with poppler >= 26.02 + poppler 26.02 dropped the reverseVideo parameter from the SplashOutputDev + constructor. Drop it from the call, guarded by a version check so older + poppler still builds. +Author: Nadzeya Hutsko <[email protected]> +Bug-Ubuntu: https://bugs.launchpad.net/bugs/2161505 +Forwarded: no +Last-Update: 2026-07-22 +--- a/bindings/poppler_splash_renderer.cc ++++ b/bindings/poppler_splash_renderer.cc +@@ -25,6 +25,7 @@ + #include <goo/GooString.h> + #include <SplashOutputDev.h> + #include <splash/SplashBitmap.h> ++#include <poppler/cpp/poppler-version.h> + + #define PDF_DOC(obj) static_cast<PDFDoc*>(obj) + #define PAGE(obj) static_cast<Page*>(obj) +@@ -43,8 +44,13 @@ + white[1] = bg_green; + white[2] = bg_blue; + // I'm not sure what bitmapRowPad should be, 1 is just a guess. ++#if POPPLER_VERSION_MAJOR > 26 || (POPPLER_VERSION_MAJOR == 26 && POPPLER_VERSION_MINOR >= 2) ++ // poppler 26.02 dropped the reverseVideo parameter. ++ void* splashDevice = new SplashOutputDev(splashModeRGB8, 1, white); ++#else + void* splashDevice = new SplashOutputDev(splashModeRGB8, 1, false, white); + #endif ++#endif + END_SYNCHRONIZED; + + return splashDevice; diff -Nru popplerkit.framework-0.0.20051227svn/debian/patches/series popplerkit.framework-0.0.20051227svn/debian/patches/series --- popplerkit.framework-0.0.20051227svn/debian/patches/series 2025-09-14 10:31:46.000000000 +0200 +++ popplerkit.framework-0.0.20051227svn/debian/patches/series 2026-07-22 12:57:50.000000000 +0200 @@ -11,3 +11,4 @@ cross.patch poppler2502.patch compiler-warnings.patch +poppler2602.patch
