Package: debhelper
Version: 14.3
Severity: normal

Hey.

This might be a duplicate of #995006... but I got a bit confused on what that's
actually about... so just merge if it's the same.


I have packages where I use something like:
```
#!/usr/bin/make -f

%:
        dh $@ --with python3 --buildsystem=pybuild


override_dh_installsystemd:
        dh_installsystemd --no-enable --no-start --no-stop-on-upgrade
```
in debian/rules.

Turns out, that whenever --no-start is used, dh omits a section like this:
```
# Automatically added by dh_installsystemd/14.3
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = 
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
        if [ -z "$DPKG_ROOT" ] && [ -d /run/systemd/system ]; then
                systemctl --system daemon-reload >/dev/null || true
                deb-systemd-invoke start 'foo.service' >/dev/null || true
        fi
fi
# End automatically added section
```
from postinst.


IMO, it should only omit the:
```
                deb-systemd-invoke start 'foo.service' >/dev/null || true
```
but keep the daemon-reload.

`--no-start`, as per documentation, simply means not to start the unit, but
that may have changed nevertheless, and people get warnings (and possibly
unexpected behaviour) if they later do any actions on it.


Thanks,
Chris.

Reply via email to