On 8/10/26 06:22, Andrew Worsley wrote:
Yep I'm missing the syntax conf variable
great, so we know the problem. :)
now, how let's find out how this file got not updated and what we can do
about it to improve/fix that.
/etc/dokuwiki/dokuwiki.php is a "conffile" (that is a specially defined
status within dpkg), that means, on upgrade if local modifications are
detected, dpkg will ask the user to a) discard the modifications, b)
keep the modifications, or c) show the differences.
I presume you selected 'keep modifications', which means the file
wasn't updated and instead, you should see a
/etc/dokuwiki/dokuwiki.php.dpkg-new or something like that.
Normally, we could just mark dokuwiki.php not being a conffile (all
files in /etc automatically have the status of a conffile, unless dpkg
is told otherwise; any other file outside of /etc is not a conffile by
default). However, that would mean, that any local modifications are
automatically discarded on upgrade, i.e. users loose their settings.
Of course, it's a bad idea to change dokuwiki.php in the first place,
all changes should go to local.php. However, users sometimes don't do that.
Now, I suggest to do the following:
* keep dokuwiki.php a conffile for now
* add a check in postinst so that after the package is installed
(i.e. after the user has chosen to keep the old dokuwiki.php)
we show a debconf warning message if the syntax option is missing
and that that needs to be added, and advise the user to use
local.php for modifications instead of dokuwiki.php.
and/or we could simply add the syntax option if it's missing.
what do you think?
Regards,
Daniel
