Package: blhc Severity: normal X-Debbugs-Cc: [email protected] Dear Maintainer,
https://salsa.debian.org/baryluk-guest/network-manager/-/jobs/10140245 2426:CFLAGS missing (-g -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection): [443/1086] /usr/bin/bpf-gcc -std=gnu17 -Wunused -Wimplicit-fallthrough -fno-stack-protector -fno-ssa-phiopt -O2 -mcpu=v3 -mco-re -gbtf -c -D__x86_64__ -mlittle-endian -I. -isystem /usr/include/x86_64-linux-gnu -idirafter /usr/include ../src/core/bpf/clat.bpf.c -o src/core/bpf/clat.bpf.unstripped.o 2426:CPPFLAGS missing (-D_FORTIFY_SOURCE=2): [443/1086] /usr/bin/bpf-gcc -std=gnu17 -Wunused -Wimplicit-fallthrough -fno-stack-protector -fno-ssa-phiopt -O2 -mcpu=v3 -mco-re -gbtf -c -D__x86_64__ -mlittle-endian -I. -isystem /usr/include/x86_64-linux-gnu -idirafter /usr/include ../src/core/bpf/clat.bpf.c -o src/core/bpf/clat.bpf.unstripped.o But I am not sure that this complain is quite correct when compiling bpf. I can imagine `-Wformat -Werror=format-security` and `-g` might be fair to include. But note that `-gbtf` is enabled, and should subsume `-g`. Do note also that upstream of the project did explicitly set `-fno-stack-protector`, likely due to issues with it in bpf programs. And `_FORTIFY_SOURCE=2` probably does not apply to bpf programs either, at least as of now. Trying to set some of these flags I get errors like: [413/1088] /usr/bin/bpf-gcc -std=gnu17 -Wunused -Wimplicit-fallthrough -fno-stack-protector -fno-ssa-phiopt -O2 -mcpu=v3 -mco-re -gbtf -g -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -D__x86_64__ -mlittle-endian -I. -isystem /usr/include/x86_64-linux-gnu -idirafter /usr/include ../src/core/bpf/clat.bpf.c -o src/core/bpf/clat.bpf.unstripped.o FAILED: [code=1] src/core/bpf/clat.bpf.unstripped.o /usr/bin/bpf-gcc -std=gnu17 -Wunused -Wimplicit-fallthrough -fno-stack-protector -fno-ssa-phiopt -O2 -mcpu=v3 -mco-re -gbtf -g -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -D__x86_64__ -mlittle-endian -I. -isystem /usr/include/x86_64-linux-gnu -idirafter /usr/include ../src/core/bpf/clat.bpf.c -o src/core/bpf/clat.bpf.unstripped.o cc1: note: ‘-fstack-protector’ does not work on this architecture cc1: error: ‘-fcf-protection=full’ is not supported for this target Regards, Witold -- System Information: Debian Release: forky/sid APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 7.2.0-rc7 (SMP w/32 CPU threads; PREEMPT) Kernel taint flags: TAINT_CPU_OUT_OF_SPEC, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) Versions of packages blhc depends on: ii libdpkg-perl 1.23.7 ii perl 5.42.2-3 blhc recommends no packages. blhc suggests no packages.
